Testing Your Code#
k0s uses github actions to run automated tests on any PR, before merging. However, a PR will not be reviewed before all tests are green, so to save time and prevent your PR from going stale, it is best to test it before submitting the PR.
Run Local Verifications#
Please run the following style and formatting commands and fix/check-in any changes:
We use golangci-lint for style verification. In the repository's root directory, simply run:
go fmt ./...
Pre-submit Flight Checks
In the repository root directory, make sure that:
make buildruns successfully. *
make check-basicruns successfully. *
make check-unithas no errors. *
make check-hacontrolplaneruns successfully.
Please note that this last test is prone to "flakiness", so it might fail on occasion. If it fails constantly, take a deeper look at your code to find the source of the problem.
If you find that all tests passed, you may open a pull request upstream.
Opening A Pull Request#
You may open a pull request in draft mode. All automated tests will still run against the PR, but the PR will not be assigned for review. Once a PR is ready for review, transition it from Draft mode, and code owners will be notified.
Once a PR has been reviewed and all other tests have passed, a code owner will run a full end-to-end conformance test against the PR. This is usually the last step before merging.
Pre-Requisites for PR Merge#
In order for a PR to be merged, the following conditions should exist:
- The PR has passed all the automated tests (style, build & conformance tests).
- PR commits have been signed with the
- PR was reviewed and approved by a code owner.
- PR is rebased against upstream's main branch.